-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localizable strings comments #283
base: main
Are you sure you want to change the base?
Conversation
The returned struct includes any comment associated with the strings file entry. Returning an array allows for future features such as detecting duplicates within a single file.
…ary to include comment parameter
# Conflicts: # ResourceApp/ResourceApp.xcodeproj/project.pbxproj
Any plan to continue and finish this work? The last update of this MR was 1.5 years ago. If no one is going to pick it up anytime soon, I would like to give it try. |
No plans from me, I ran outta steam. |
We sort of stopped with this PR when @mac-cain13 and I realised we didn't want to replace your Strings parser, but only augment it. So only build a Strings Comment parser, and combine that with the existing Strings parser. That way, existing file won't break if the new parser isn't perfect. Anyway, that was the idea, but we never did anything more with it. |
@tomlokhorst Are we going to see #232 in production any time soon, please? |
Implements #232, continuation of #235
I've merged the current master branch into @nolanw's code, making it all Swift 3.
Todo:
\n
[1]: Instead of flat out replacing the existing LocalizedStrings parser, we could split out the comments parser. That way, if there's an error in our own parser, the localized strings will still be generated, just with missing comments.