Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a simple development for xcstrings support.
It is backward compatible for for
.xcstrings
files converted from.strings
files. It means the same R.string codes will be generated.However, it is not backward compatible for
.xcstrings
files converted from.stringsdict
files, because of named arguments.About named arguments
My implementation strips names of substitutions from generated arguments. I found using them problematic on some cases.
In my opinion, named arguments does not worth the implementation. Xcode generates substituons only if there are more than one pluralable parameter on new xcstrings files. The most of the string values will not be have any information to generate named arguments.
Problematic case 1
Some key information is lost on the xcstring convertion of stringsdict files.
Original stringsdict content.
Generated xcstrings content
R.swift creates .x_users(users: Int) for stringsdict file. However, xcstrings file does not have the argument name information any more.
If string value of the original content is
<string>Add %#@users@</string>
, generated xcstrings would keep the substitution information.Problematic case 2
This strings value is "1 iPhone and 10 touches" on iPhones and "1 Mac and 10 keys" on Mac.
There are 2 substitutions for each device variation.
Which signature should we use?
.example(device_iphone: Int, input_iphone: Int)
.example(device_mac: Int, input_mac: Int)
.example(_ arg1: Int, _ arg2: Int)
.example(device Int, input: Int) //With some extra coding to detect shared parts of the names.
About algorithm
The alghorithm tries to convert localization of source language to single string with basic format parameters, then it uses FormatPart.formatParts(formatString:)` on this string to extract parameters.
This convertion works like that:
Substitutions replacement works like that:
Example 1
Example 2
Example 3
%#@books@ and %#@pens@
%arg book
%1$lld book
%1$lld book and %#@pens@
%arg pen
%2$lld pen
%1$lld book and%2$lld pen
%1$lld book and %2$lld pen
. [%lld, %lld]