Accept optional [preferredLanguages] #923
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tomlokhorst I would appreciate a review 🙏 |
|
Thank you for this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. I've been happily using R.swift for a long time now, so I missed the whole 6.x version and now I am migrating from the version 5 to the version 7. Everything seems to be really smooth (thanks!) except one little thing: previously
preferredLanguagesparameter did acceptnil, so I can pass it down my call chain if I want to, and now I can no longer do that. Funny enough, it seems every part of R.swift still acceptspreferredLanguages: niljust fine, except the very top autogenerated file. Here is the PR to fix that.One note: I could not locate where the tests of those are located, I can only see the example app, which doesn't really test anything, so I am kinda confused here.