Add not found responses for aggregates and contributions

macladson · Mar 2, 2022 · 5d793bf · 5d793bf
1 parent a7439b0
commit 5d793bf
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 11 deletions.
diff --git a/apis/validator/aggregate_attestation.yaml b/apis/validator/aggregate_attestation.yaml
@@ -9,7 +9,7 @@ get:
     - name: attestation_data_root
       in: query
       required: true
-      description: "HashTreeRoot of AttestationData that validator want's aggregated"
+      description: "HashTreeRoot of AttestationData that validator wants aggregated"
       schema:
         $ref: '../../beacon-node-oapi.yaml#/components/schemas/Root'
     - name: slot
@@ -29,15 +29,8 @@ get:
               data:
                 $ref: '../../beacon-node-oapi.yaml#/components/schemas/Attestation'
     "400":
-      description: "Invalid request"
-      content:
-        application/json:
-          schema:
-            $ref: "../../beacon-node-oapi.yaml#/components/schemas/ErrorMessage"
-          examples:
-            NotAggregator:
-              value:
-                code: 403
-                message: Beacon node was not assigned to aggregate on that subnet.
+      $ref: '../../beacon-node-oapi.yaml#/components/responses/InvalidRequest'
+    "404":
+      $ref: '../../beacon-node-oapi.yaml#/components/responses/NotFound'
     "500":
       $ref: '../../beacon-node-oapi.yaml#/components/responses/InternalError'
diff --git a/apis/validator/sync_committee_contribution.yaml b/apis/validator/sync_committee_contribution.yaml
@@ -37,6 +37,8 @@ get:
                 $ref: '../../beacon-node-oapi.yaml#/components/schemas/Altair.SyncCommitteeContribution'
     "400":
       $ref: '../../beacon-node-oapi.yaml#/components/responses/InvalidRequest'
+    "404":
+      $ref: '../../beacon-node-oapi.yaml#/components/responses/NotFound'
     "500":
       $ref: '../../beacon-node-oapi.yaml#/components/responses/InternalError'
     "503":

diff --git a/beacon-node-oapi.yaml b/beacon-node-oapi.yaml
@@ -255,6 +255,8 @@ components:
   responses:
     InvalidRequest:
       $ref: './types/http.yaml#/InvalidRequest'
+    NotFound:
+      $ref: './types/http.yaml#/NotFound'
     InternalError:
       $ref: './types/http.yaml#/InternalError'
     CurrentlySyncing: