Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(coverage): streamline e2e and coverage test script #454

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

jbcaron
Copy link
Member

@jbcaron jbcaron commented Jan 6, 2025

Pull Request type

Please add the labels corresponding to the type of changes your PR introduces:

  • Build-related changes

What is the current behavior?

An Anvil instance is launched for E2E tests, whereas now a shared instance is launched directly from the rust tests.

Resolves: #NA

What is the new behavior?

Does this introduce a breaking change?

No

Other information

@jbcaron jbcaron self-assigned this Jan 6, 2025
@Trantorian1
Copy link
Collaborator

Please more info to the pr description, it is not currently clear what this is about unless you check the code out.

Copy link
Collaborator

@Trantorian1 Trantorian1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Trantorian1 Trantorian1 changed the title chore: streamline e2e and coverage test script chore(coverage): streamline e2e and coverage test script Jan 7, 2025
Copy link
Contributor

@notlesh notlesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but could you leave a link to some more info about how anvil is now automatically launched with the rust tests?

@antiyro antiyro merged commit 1fda456 into main Jan 7, 2025
10 checks passed
@jbcaron
Copy link
Member Author

jbcaron commented Jan 7, 2025

pub fn get_shared_anvil() -> Arc<AnvilInstance> {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants