-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): integrate yamllint and alejandra linters #455
base: main
Are you sure you want to change the base?
Conversation
ee32952
to
d107522
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps it is worth updating scripts/madara
as it has a lint
command which lints the project.
@@ -1,87 +1,84 @@ | |||
--- | |||
- name: "breaking-change" | |||
- name: breaking-change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we enforce some kind of spacing between sections for his kind of file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we can keep empty lines in yaml? wdyt?
- uses: foundry-rs/foundry-toolchain@v1 | ||
with: | ||
version: nightly | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest keeping line breaks between YAML sections as it follows standard formatting practices and improves readability.
Pull Request type
Please add the labels corresponding to the type of changes your PR introduces:
What is the current behavior?
Currently, YAML files are only validated through Prettier, which primarily focuses on basic formatting. This limited approach may miss YAML-specific syntax issues and doesn't enforce consistent YAML style guidelines. Additionally, there is no dedicated linting for Nix files in the repository.
Resolves: #NA
What is the new behavior?
Does this introduce a breaking change?
No
Other information
This PR is part of our ongoing effort to improve code quality and consistency across the codebase. The linting rules have been configured to be strict enough to catch common issues while remaining flexible enough to not impede development workflow.
To test locally: