Skip to content

Commit

Permalink
Reviewed all remaining TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
madelson committed Aug 23, 2014
1 parent 0f6728f commit d222187
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 6 deletions.
2 changes: 0 additions & 2 deletions MedallionShell.Tests/GeneralTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,5 @@ private IEnumerable<string> ErrorLines()
yield return "1";
throw new InvalidOperationException("Can't enumerate");
}

// TODO more error handling tests
}
}
1 change: 0 additions & 1 deletion MedallionShell/Command.cs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ namespace Medallion.Shell
// Not clear how valuable this is, though
// TODO cancellation token support
// TODO ToString() implementations
// TODO README
// TODO README links to NuGet, codeducky
// deadlocking
// TODO codeducky post
Expand Down
2 changes: 1 addition & 1 deletion MedallionShell/Shell.cs
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ public Command Run(string executable, params object[] arguments)
}
#endregion

// TODO Run static methods, change instance to Execute
// TODO do we want to support static Run-type methods here as well?
#region ---- Static API ----
private static readonly Shell DefaultShell = new Shell();
/// <summary>
Expand Down
1 change: 0 additions & 1 deletion MedallionShell/Streams/ProcessStreamHandler.cs
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ private enum Mode
/// </summary>
private readonly TaskCompletionSource<bool> taskCompletionSource = new TaskCompletionSource<bool>();

// TODO we don't really need this
private readonly Task readLoopTask;

public ProcessStreamHandler(StreamReader reader)
Expand Down
3 changes: 2 additions & 1 deletion MedallionShell/WindowsCommandLineSyntax.cs
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ private static string EscapeArgument(string argument)
// http://stackoverflow.com/questions/5510343/escape-command-line-arguments-in-c-sharp
// Note: at the time of this writing, the posted answer didn't quite work as written. There was a comment
// mentioning the correction, and I've submitted it as an edit (the groupings in the original post are wrong)
// TODO the post also mentions another method that only quotes when necessary. Should we use that?

// TODO the thread also mentions another method that only quotes when necessary. Should we use that?

// find each substring of 0-or-more \ followed by " and replace it by twice-as-many \, followed by \".
var singleQuotesEscaped = Regex.Replace(argument, @"(\\*)" + "\"", @"$1$1\" + "\"");
Expand Down

0 comments on commit d222187

Please sign in to comment.