Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve lint #20

Merged
merged 1 commit into from
Oct 5, 2019
Merged

Conversation

coderaiser
Copy link
Contributor

@coderaiser coderaiser commented Oct 4, 2019

Description

Fixes # (issue) #16

Type of change

Please delete options that are not relevant.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@welcome
Copy link

welcome bot commented Oct 4, 2019

Thanks for opening this pull request! Please check out our contributing guidelines.

@jamesgeorge007 jamesgeorge007 self-requested a review October 5, 2019 06:39
@jamesgeorge007 jamesgeorge007 added code refactoring attempt to eliminate code redundancy Hacktoberfest labels Oct 5, 2019
Copy link
Member

@jamesgeorge007 jamesgeorge007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👏

@jamesgeorge007 jamesgeorge007 merged commit bf4e44a into madlabsinc:next Oct 5, 2019
@welcome
Copy link

welcome bot commented Oct 5, 2019

congrats
Congrats on your very first contribution 👏 Looking forward to having more from your side

@coderaiser coderaiser deleted the refactor branch October 7, 2019 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code refactoring attempt to eliminate code redundancy Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants