Extract CSS to File for Import #154
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big fan of the work done for this Remote Card, much appreciated to all those involved!
I use the basis of this repo to produce multiple different Remotes (e.g. an IR Based Remote), that follow the same format as this. In doing some I've done a fair bit of refactoring to make the code more reusable.
Extracting the CSS to a seperate File allows me to use the same CSS across multiple Remotes without having to copy/paste into the new Remote, keeping the Styles consistent.
This is just one of the changes I've made, whether this is welcome is up to you but happy to contribute all of the work I've done on this project with further PRs.