Skip to content

Commit

Permalink
Update Server version to valkey version
Browse files Browse the repository at this point in the history
Signed-off-by: Madelyn Olson <[email protected]>
  • Loading branch information
madolson committed Apr 5, 2024
1 parent 47444c6 commit f86dc5e
Show file tree
Hide file tree
Showing 15 changed files with 25 additions and 27 deletions.
2 changes: 1 addition & 1 deletion src/cli_common.c
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ sds escapeJsonString(sds s, const char *p, size_t len) {
}

sds cliVersion(void) {
sds version = sdscatprintf(sdsempty(), "%s", SERVER_VERSION);
sds version = sdscatprintf(sdsempty(), "%s", VALKEY_VERSION);

/* Add git commit and working tree status when available. */
if (strtoll(serverGitSHA1(),NULL,16)) {
Expand Down
2 changes: 1 addition & 1 deletion src/config.c
Original file line number Diff line number Diff line change
Expand Up @@ -634,7 +634,7 @@ void loadServerConfigFromString(char *config) {

loaderr:
if (argv) sdsfreesplitres(argv,argc);
fprintf(stderr, "\n*** FATAL CONFIG FILE ERROR (Version %s) ***\n", SERVER_VERSION);
fprintf(stderr, "\n*** FATAL CONFIG FILE ERROR (Version %s) ***\n", VALKEY_VERSION);
if (i < totlines) {
fprintf(stderr, "Reading the configuration file, at line %d\n", linenum);
fprintf(stderr, ">>> '%s'\n", lines[i]);
Expand Down
2 changes: 1 addition & 1 deletion src/debug.c
Original file line number Diff line number Diff line change
Expand Up @@ -2252,7 +2252,7 @@ static void sigsegvHandler(int sig, siginfo_t *info, void *secret) {

bugReportStart();
serverLog(LL_WARNING,
SERVER_NAME " %s crashed by signal: %d, si_code: %d", SERVER_VERSION, sig, info->si_code);
SERVER_NAME " %s crashed by signal: %d, si_code: %d", VALKEY_VERSION, sig, info->si_code);
if (sig == SIGSEGV || sig == SIGBUS) {
serverLog(LL_WARNING,
"Accessing address: %p", (void*)info->si_addr);
Expand Down
4 changes: 2 additions & 2 deletions src/lolwut.c
Original file line number Diff line number Diff line change
Expand Up @@ -44,15 +44,15 @@ void lolwut6Command(client *c);
* This is what unstable versions of Redis will display. */
void lolwutUnstableCommand(client *c) {
sds rendered = sdsnew("Redis ver. ");
rendered = sdscat(rendered,SERVER_VERSION);
rendered = sdscat(rendered,VALKEY_VERSION);
rendered = sdscatlen(rendered,"\n",1);
addReplyVerbatim(c,rendered,sdslen(rendered),"txt");
sdsfree(rendered);
}

/* LOLWUT [VERSION <version>] [... version specific arguments ...] */
void lolwutCommand(client *c) {
char *v = SERVER_VERSION;
char *v = VALKEY_VERSION;
char verstr[64];

if (c->argc >= 3 && !strcasecmp(c->argv[1]->ptr,"version")) {
Expand Down
2 changes: 1 addition & 1 deletion src/lolwut5.c
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ void lolwut5Command(client *c) {
sds rendered = renderCanvas(canvas);
rendered = sdscat(rendered,
"\nGeorg Nees - schotter, plotter on paper, 1968. Redis ver. ");
rendered = sdscat(rendered,SERVER_VERSION);
rendered = sdscat(rendered,VALKEY_VERSION);
rendered = sdscatlen(rendered,"\n",1);
addReplyVerbatim(c,rendered,sdslen(rendered),"txt");
sdsfree(rendered);
Expand Down
2 changes: 1 addition & 1 deletion src/lolwut6.c
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ void lolwut6Command(client *c) {
rendered = sdscat(rendered,
"\nDedicated to the 8 bit game developers of past and present.\n"
"Original 8 bit image from Plaguemon by hikikomori. Redis ver. ");
rendered = sdscat(rendered,SERVER_VERSION);
rendered = sdscat(rendered,VALKEY_VERSION);
rendered = sdscatlen(rendered,"\n",1);
addReplyVerbatim(c,rendered,sdslen(rendered),"txt");
sdsfree(rendered);
Expand Down
2 changes: 1 addition & 1 deletion src/mkreleasehdr.sh
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ echo "#define REDIS_GIT_SHA1 \"$GIT_SHA1\"" > release.h
echo "#define REDIS_GIT_DIRTY \"$GIT_DIRTY\"" >> release.h
echo "#define REDIS_BUILD_ID \"$BUILD_ID\"" >> release.h
echo "#include \"version.h\"" >> release.h
echo "#define REDIS_BUILD_ID_RAW SERVER_NAME SERVER_VERSION REDIS_BUILD_ID REDIS_GIT_DIRTY REDIS_GIT_SHA1" >> release.h
echo "#define REDIS_BUILD_ID_RAW SERVER_NAME VALKEY_VERSION REDIS_BUILD_ID REDIS_GIT_DIRTY REDIS_GIT_SHA1" >> release.h
touch release.c # Force recompile of release.c
2 changes: 1 addition & 1 deletion src/module.c
Original file line number Diff line number Diff line change
Expand Up @@ -13295,7 +13295,7 @@ int RM_GetKeyspaceNotificationFlagsAll(void) {
* Example for 6.0.7 the return value will be 0x00060007.
*/
int RM_GetServerVersion(void) {
return SERVER_VERSION_NUM;
return VALKEY_VERSION_NUM;
}

/**
Expand Down
2 changes: 1 addition & 1 deletion src/networking.c
Original file line number Diff line number Diff line change
Expand Up @@ -3650,7 +3650,7 @@ void helloCommand(client *c) {
addReplyBulkCString(c,"redis");

addReplyBulkCString(c,"version");
addReplyBulkCString(c,SERVER_VERSION);
addReplyBulkCString(c,VALKEY_VERSION);

addReplyBulkCString(c,"proto");
addReplyLongLong(c,c->resp);
Expand Down
8 changes: 3 additions & 5 deletions src/rdb.c
Original file line number Diff line number Diff line change
Expand Up @@ -1195,9 +1195,7 @@ int rdbSaveInfoAuxFields(rio *rdb, int rdbflags, rdbSaveInfo *rsi) {
int aof_base = (rdbflags & RDBFLAGS_AOF_PREAMBLE) != 0;

/* Add a few fields about the state when the RDB was created. */
if (rdbSaveAuxFieldStrStr(rdb,"server-ver",SERVER_VERSION) == -1) return -1;
/* Print Redis version for backwards compatibility with redis. */
if (rdbSaveAuxFieldStrStr(rdb,"redis-ver",REDIS_VERSION) == -1) return -1;
if (rdbSaveAuxFieldStrStr(rdb,"valkey-ver",VALKEY_VERSION) == -1) return -1;
if (rdbSaveAuxFieldStrInt(rdb,"redis-bits",redis_bits) == -1) return -1;
if (rdbSaveAuxFieldStrInt(rdb,"ctime",time(NULL)) == -1) return -1;
if (rdbSaveAuxFieldStrInt(rdb,"used-mem",zmalloc_used_memory()) == -1) return -1;
Expand Down Expand Up @@ -3166,8 +3164,8 @@ int rdbLoadRioWithLoadingCtx(rio *rdb, int rdbflags, rdbSaveInfo *rsi, rdbLoadin
} else if (!strcasecmp(auxkey->ptr,"redis-ver")) {
serverLog(LL_NOTICE,"Loading RDB produced by Redis version %s",
(char*)auxval->ptr);
} else if (!strcasecmp(auxkey->ptr,"server-ver")) {
serverLog(LL_NOTICE,"Loading RDB produced by server version %s",
} else if (!strcasecmp(auxkey->ptr,"valkey-ver")) {
serverLog(LL_NOTICE,"Loading RDB produced by valkey version %s",
(char*)auxval->ptr);
} else if (!strcasecmp(auxkey->ptr,"ctime")) {
time_t age = time(NULL)-strtol(auxval->ptr,NULL,10);
Expand Down
8 changes: 4 additions & 4 deletions src/script_lua.c
Original file line number Diff line number Diff line change
Expand Up @@ -1393,12 +1393,12 @@ void luaRegisterVersion(lua_State* lua) {
lua_settable(lua,-3);

/* Now push the Valkey version information. */
lua_pushstring(lua,"SERVER_VERSION_NUM");
lua_pushnumber(lua,SERVER_VERSION_NUM);
lua_pushstring(lua,"VALKEY_VERSION_NUM");
lua_pushnumber(lua,VALKEY_VERSION_NUM);
lua_settable(lua,-3);

lua_pushstring(lua,"SERVER_VERSION");
lua_pushstring(lua,SERVER_VERSION);
lua_pushstring(lua,"VALKEY_VERSION");
lua_pushstring(lua,VALKEY_VERSION);
lua_settable(lua,-3);

lua_pushstring(lua,"SERVER_NAME");
Expand Down
2 changes: 1 addition & 1 deletion src/sentinel.c
Original file line number Diff line number Diff line change
Expand Up @@ -1846,7 +1846,7 @@ void loadSentinelConfigFromQueue(void) {
return;

loaderr:
fprintf(stderr, "\n*** FATAL CONFIG FILE ERROR (Version %s) ***\n", SERVER_VERSION);
fprintf(stderr, "\n*** FATAL CONFIG FILE ERROR (Version %s) ***\n", VALKEY_VERSION);
fprintf(stderr, "Reading the configuration file, at line %d\n", linenum);
fprintf(stderr, ">>> '%s'\n", line);
fprintf(stderr, "%s\n", err);
Expand Down
8 changes: 4 additions & 4 deletions src/server.c
Original file line number Diff line number Diff line change
Expand Up @@ -5586,7 +5586,7 @@ sds genRedisInfoString(dict *section_dict, int all_sections, int everything) {
info = sdscatfmt(info, "# Server\r\n" FMTARGS(
"redis_version:%s\r\n", REDIS_VERSION,
"server_name:%s\r\n", SERVER_NAME,
"server_version:%s\r\n", SERVER_VERSION,
"valkey_version:%s\r\n", VALKEY_VERSION,
"redis_git_sha1:%s\r\n", serverGitSHA1(),
"redis_git_dirty:%i\r\n", strtol(serverGitDirty(),NULL,10) > 0,
"redis_build_id:%s\r\n", serverBuildIdString(),
Expand Down Expand Up @@ -6267,7 +6267,7 @@ void daemonize(void) {
sds getVersion(void) {
sds version = sdscatprintf(sdsempty(),
"v=%s sha=%s:%d malloc=%s bits=%d build=%llx",
SERVER_VERSION,
VALKEY_VERSION,
serverGitSHA1(),
atoi(serverGitDirty()) > 0,
ZMALLOC_LIB,
Expand Down Expand Up @@ -6321,7 +6321,7 @@ void serverAsciiArt(void) {
);
} else {
snprintf(buf,1024*16,ascii_logo,
SERVER_VERSION,
VALKEY_VERSION,
serverGitSHA1(),
strtol(serverGitDirty(),NULL,10) > 0,
(sizeof(long) == 8) ? "64" : "32",
Expand Down Expand Up @@ -7156,7 +7156,7 @@ int main(int argc, char **argv) {

serverLog(LL_NOTICE, "oO0OoO0OoO0Oo Redis is starting oO0OoO0OoO0Oo");
serverLog(LL_NOTICE, SERVER_NAME " version=%s, bits=%d, commit=%s, modified=%d, pid=%d, just started",
SERVER_VERSION,
VALKEY_VERSION,
(sizeof(long) == 8) ? 64 : 32,
serverGitSHA1(),
strtol(serverGitDirty(),NULL,10) > 0,
Expand Down
4 changes: 2 additions & 2 deletions src/version.h
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#define SERVER_NAME "valkey"
#define SERVER_VERSION "255.255.255"
#define SERVER_VERSION_NUM 0x00ffffff
#define VALKEY_VERSION "255.255.255"
#define VALKEY_VERSION_NUM 0x00ffffff

/* Redis compatibility version, should never
* exceed 7.2.x. */
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/moduleapi/misc.tcl
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ start_server {overrides {save {900 1}} tags {"modules"}} {
}

test {test redis version} {
assert_equal [s server_version] [r test.redisversion]
assert_equal [s valkey_version] [r test.redisversion]
}

test {test long double conversions} {
Expand Down

0 comments on commit f86dc5e

Please sign in to comment.