Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update the AccountAddressesQueryParams interface #49

Conversation

stanvladut
Copy link
Contributor

@stanvladut stanvladut commented Oct 9, 2024

Update the AccountAddressesQueryParams interface to include include_empty query param.
Reference: https://docs.gomaestro.org/Cardano/Indexer-API/Accounts/account-addresses

Summary

Please provide a brief, concise summary of the changes in your pull request. Explain the problem you are trying to solve and the solution you have implemented.

Type of Change

Please mark the relevant option(s) for your pull request:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring (improving code quality without changing its behavior)
  • Documentation update (adding or updating documentation related to the project)

Checklist

Please ensure that your pull request meets the following criteria:

  • I have read the Contributing Guide
  • My code follows the project's coding style and best practices
  • My code is appropriately commented and includes relevant documentation
  • I have added tests to cover my changes
  • All new and existing tests pass
  • I have updated the documentation, if necessary

Testing

Please describe the tests you have added or modified, and provide any additional context or instructions needed to run the tests.

  • Test A
  • Test B

Additional Information

If you have any additional information or context to provide, such as screenshots, relevant issues, or other details, please include them here.

@stanvladut stanvladut requested a review from a team as a code owner October 9, 2024 13:08
Vardominator
Vardominator previously approved these changes Oct 9, 2024
@Vardominator
Copy link
Contributor

@stanvladut Thanks for contribution! Can you please pull from upstream main and also bump version in package.json to 1.6.2?

@Vardominator Vardominator merged commit 9b6deef into maestro-org:main Dec 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants