generated from athackst/vscode_ros2_workspace
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redis integration #48
Merged
maffettone
merged 11 commits into
maffettone:humble
from
ChandimaFernando:redis_integration
Oct 22, 2024
Merged
Redis integration #48
maffettone
merged 11 commits into
maffettone:humble
from
ChandimaFernando:redis_integration
Oct 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maffettone
reviewed
Oct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! A few comments to chat over, but all in all great progress.
Comment on lines
6
to
11
import rclpy | ||
from rclpy.action import ActionClient | ||
from rclpy.node import Node | ||
|
||
from pdf_beamtime_interfaces.action import FidPoseControlMsg | ||
import redis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
import rclpy | |
from rclpy.action import ActionClient | |
from rclpy.node import Node | |
from pdf_beamtime_interfaces.action import FidPoseControlMsg | |
import redis | |
import rclpy | |
from rclpy.action import ActionClient | |
from rclpy.node import Node | |
import redis | |
from pdf_beamtime_interfaces.action import FidPoseControlMsg |
This should fix the isort.
Co-authored-by: Dr. Phil Maffettone <[email protected]>
maffettone
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR connects a Redis database to extract the tag ID corresponding to a given sample.