Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis integration #48

Merged
merged 11 commits into from
Oct 22, 2024
Merged

Conversation

ChandimaFernando
Copy link
Collaborator

This PR connects a Redis database to extract the tag ID corresponding to a given sample.

Copy link
Owner

@maffettone maffettone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! A few comments to chat over, but all in all great progress.

src/aruco_pose/README.md Outdated Show resolved Hide resolved
src/aruco_pose/README.md Show resolved Hide resolved
src/aruco_pose/README.md Outdated Show resolved Hide resolved
src/aruco_pose/src/redis_insert.py Show resolved Hide resolved
Comment on lines 6 to 11
import rclpy
from rclpy.action import ActionClient
from rclpy.node import Node

from pdf_beamtime_interfaces.action import FidPoseControlMsg
import redis
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import rclpy
from rclpy.action import ActionClient
from rclpy.node import Node
from pdf_beamtime_interfaces.action import FidPoseControlMsg
import redis
import rclpy
from rclpy.action import ActionClient
from rclpy.node import Node
import redis
from pdf_beamtime_interfaces.action import FidPoseControlMsg

This should fix the isort.

@ChandimaFernando ChandimaFernando marked this pull request as ready for review October 22, 2024 18:41
@maffettone maffettone merged commit d3ac840 into maffettone:humble Oct 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants