-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft | prototype for a rule optimiser #5
Open
MartiPuigV
wants to merge
37
commits into
magenta-aps:main
Choose a base branch
from
MartiPuigV:rule_optimiser
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m height and causing it to stretch. It also does not reload the page, causing a useless miniscan() from the backend.
… for text input field is hard-coded at 2000 in checkTextSize.js
…js file that handled that before as well as prior translations.
…supported at the moment.
…s/miniscanner/miniscan_results.html Co-authored-by: Alexander Faithfull <[email protected]>
…html Co-authored-by: Alexander Faithfull <[email protected]>
Co-authored-by: Alexander Faithfull <[email protected]>
…d test_miniscanner now have variable and function names in snake_case.
…so fixed the redundant class problem in the test file.
… not( and( 1, 2, 3, ) ). Coming soon
…ry in advance for anyone reading this. It works tho on most edge cases.
…be run in two lines.
…of the RuleOptimiser
…ersonnames, addresses, etc ). These rules get converted to numbers and then back to rules when the script had done its magic
Usage : input file with the rule given by the user, and output file for temporary storage. It doesn't get deleted yet for testing purposes and to check out the results, but can probably be stored in some tmp/tmpdir later on and removed. Check optimiser_usage.py for how to run the rule optimiser. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loads a rule (coming from the miniscanner or real datascanner, and returns a clean rule without redundacnies and useless expressions. Doesn't work 100%, but does the trick for most complicated and repetitive rules.