Skip to content

Commit

Permalink
[refactor] Move blackhole implementation to internal package (jaege…
Browse files Browse the repository at this point in the history
…rtracing#6647)

## Which problem is this PR solving?
- Towards jaegertracing#6637

## Description of the changes
- This PR moves the implementation for blackhole storage from
`plugin/storage/` to `internal/storage/`

## How was this change tested?
- CI

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

---------

Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
  • Loading branch information
mahadzaryab1 authored Feb 2, 2025
1 parent d590c11 commit 92246c5
Show file tree
Hide file tree
Showing 6 changed files with 1 addition and 1 deletion.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion plugin/storage/factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,13 @@ import (

"github.com/jaegertracing/jaeger/internal/safeexpvar"
"github.com/jaegertracing/jaeger/internal/storage/v1/badger"
"github.com/jaegertracing/jaeger/internal/storage/v1/blackhole"
"github.com/jaegertracing/jaeger/internal/storage/v1/cassandra"
"github.com/jaegertracing/jaeger/internal/storage/v1/es"
"github.com/jaegertracing/jaeger/internal/storage/v1/grpc"
"github.com/jaegertracing/jaeger/internal/storage/v1/memory"
"github.com/jaegertracing/jaeger/pkg/metrics"
"github.com/jaegertracing/jaeger/plugin"
"github.com/jaegertracing/jaeger/plugin/storage/blackhole"
"github.com/jaegertracing/jaeger/plugin/storage/kafka"
"github.com/jaegertracing/jaeger/storage"
"github.com/jaegertracing/jaeger/storage/dependencystore"
Expand Down

0 comments on commit 92246c5

Please sign in to comment.