Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to PopScope and Fix back button not showing destination issue #52

Merged
merged 5 commits into from
Jul 12, 2024

Conversation

maheshj01
Copy link
Owner

Fix : #48 #49 #51

  • Migrate WillPopScope to PopScope Issue 48
  • Fix Deprecation Issue 49
  • Migrate example app to Flutter's Gradle plugins
  • Fix: Navbar Destination not updating on backbutton press Issue 51
  • docs: Navbar Router should be wrapped in builder for Snackbar to work

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing using flutter test

If you need help, consider pinging the maintainer @maheshmnj

@maheshj01 maheshj01 merged commit 1d020ed into main Jul 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WillPopScope' is deprecated and shouldn't be used. Use PopScope instead.
1 participant