-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Another php8.1 upgrade #2418
base: main
Are you sure you want to change the base?
Another php8.1 upgrade #2418
Conversation
Just double-checking, there are no backward incompatible changes between v8.0 and v8.1 in our repo? |
+1 from me |
These are covered in the individual packages. Roundcube 1.6 introduced PHP 8.1 and is backwards compatible with 8.0. Z-Push 2.7.1 Fixed the only PHP 8.1 specific issue that has been come across. There is still PHP 8.0 errors coming up and being fixed though. 2.7.4 has some more of these. Z-Push will be aiming to maintain PHP 7.4 to latest PHP. I don't think there are any problems with moving to 8.1. |
Great, thanks. Will leave it to @JoshData to review + merge, then I will do the next part, the NC upgrade. |
@JoshData Since there was a new release, I wonder why this isn't merged yet? |
My guess is that I haven't nailed it and it will take alot of Josh's time to review and provide guidance. Probably more than him doing the work himself. I wasn't going to chase him up, and give him the space to get to it when he can. |
This is my take on upgrading to PHP 8.1 with the feedback from @kiekerjan's PR #2309.
Would probably like to move the PHP Version from the if on line 94 in nextcloud.sh and make it an additional mandatory argument for the InstallNextcloud() function. But to keep this PR simple initially I have foregone that.
I have tested this with upgrading from a v57a backup (nextcloud 20.0.14) successfully.