Merge pull request #286 from OFFLINE-GmbH/move-url-validation

Changed url validation

httphelpers.go

@@ -17,7 +17,7 @@ import (
 	"strings"
 )
 
-var validURL = regexp.MustCompile(`^/v[2-4].*`)
+var validURL = regexp.MustCompile(`/v[2-4].*`)
 
 type httpRequest struct {
 	URL               string

mailgun_test.go

@@ -2,7 +2,10 @@ package mailgun_test
 
 import (
 	"context"
+	"encoding/json"
+	"fmt"
 	"net/http"
+	"net/http/httptest"
 	"testing"
 
 	"github.com/facebookgo/ensure"
@@ -33,3 +36,27 @@ func TestInvalidBaseAPI(t *testing.T) {
 	ensure.NotNil(t, err)
 	ensure.DeepEqual(t, err.Error(), `BaseAPI must end with a /v2, /v3 or /v4; setBaseAPI("https://host/v3")`)
 }
+
+func TestValidBaseAPI(t *testing.T) {
+	testServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		var resp mailgun.DomainResponse
+		b, err := json.Marshal(resp)
+		ensure.Nil(t, err)
+
+		w.Write(b)
+	}))
+
+	apiBases := []string{
+		fmt.Sprintf("%s/v3", testServer.URL),
+		fmt.Sprintf("%s/proxy/v3", testServer.URL),
+	}
+
+	for _, apiBase := range apiBases {
+		mg := mailgun.NewMailgun(testDomain, testKey)
+		mg.SetAPIBase(apiBase)
+
+		ctx := context.Background()
+		_, err := mg.GetDomain(ctx, "unknown.domain")
+		ensure.Nil(t, err)
+	}
+}