Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DE-1386 removed deprecated (mg *MailgunImpl) NewMessage method #365

Merged
merged 1 commit into from
Dec 15, 2024
Merged

DE-1386 removed deprecated (mg *MailgunImpl) NewMessage method #365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions mailgun.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,6 @@ type Mailgun interface {
// TODO(v5): switch m to SendableMessage interface
Send(ctx context.Context, m *Message) (mes string, id string, err error)
ReSend(ctx context.Context, id string, recipients ...string) (string, string, error)
// Deprecated: use func NewMessage instead of method.
NewMessage(from, subject, text string, to ...string) *Message
// Deprecated: use func NewMIMEMessage instead of method.
NewMIMEMessage(body io.ReadCloser, to ...string) *Message

Expand Down
7 changes: 0 additions & 7 deletions messages.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,13 +204,6 @@ func NewMessage(from, subject, text string, to ...string) *Message {
}
}

// Deprecated: use func NewMessage instead of method.
//
// TODO(v5): remove this method
func (*MailgunImpl) NewMessage(from, subject, text string, to ...string) *Message {
return NewMessage(from, subject, text, to...)
}

// NewMIMEMessage creates a new MIME message. These messages are largely canned;
// you do not need to invoke setters to set message-related headers.
// However, you do still need to call setters for Mailgun-specific settings.
Expand Down
Loading