Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DE-1387 Release v5 #367

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

DE-1387 Release v5 #367

wants to merge 16 commits into from

Conversation

vtopc
Copy link
Contributor

@vtopc vtopc commented Dec 15, 2024

Changes:

  • Send(ctx context.Context, m SendableMessage) (mes string, id string, err error) now accepts interface - https://bryanftan.medium.com/accept-interfaces-return-structs-in-go-d4cab29a301b
  • Mailgun client is now domain agnostic:
    • No need to pass the domain into the func mailgun.NewMailgun
    • Many methods now require passing a domain, which indicates which methods are domain-specific and which are global for your account.
      • Pay attention to that func NewMessage(domain, from, subject, text string, to ...string) *PlainMessage has a variadic to argument, so there would be no compile error if you miss passing domain.
  • SetAPIBase() now returns an error.
  • For the EU: do mg.SetAPIBase(mailgun.APIBaseEU) instead of mg.SetAPIBase("https://api.eu.mailgun.net/v...").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant