-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
De 1301 mailgun sdk the template search filters do not match the documentation #914
Merged
oleksandr-mykhailenko
merged 18 commits into
master
from
DE-1301-mailgun-sdk-the-template-search-filters-do-not-match-the-documentation
Jul 30, 2024
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
2f6f7aa
Add dependabot. Change php-cs-fixer
oleksandr-mykhailenko e7e227e
Merge branch 'master' of github.com:mailgun/mailgun-php
oleksandr-mykhailenko fca806c
Merge branch 'master' of github.com:mailgun/mailgun-php
oleksandr-mykhailenko 6499a70
Merge branch 'master' of github.com:mailgun/mailgun-php
oleksandr-mykhailenko 017fac4
Merge branch 'master' of github.com:mailgun/mailgun-php
oleksandr-mykhailenko b568e7a
Merge branch 'master' of github.com:mailgun/mailgun-php
oleksandr-mykhailenko 2e906af
Merge branch 'master' of github.com:mailgun/mailgun-php
oleksandr-mykhailenko f84822d
Domains. V4
oleksandr-mykhailenko 36f1cf3
Merge branch 'master' of github.com:mailgun/mailgun-php
oleksandr-mykhailenko 8ffe44d
Merge branch 'master' of github.com:mailgun/mailgun-php
oleksandr-mykhailenko 383e36f
Merge branch 'master' of github.com:mailgun/mailgun-php
oleksandr-mykhailenko 4e98711
Merge branch 'master' of github.com:mailgun/mailgun-php
oleksandr-mykhailenko 6971c50
Merge branch 'master' of github.com:mailgun/mailgun-php
oleksandr-mykhailenko 4891e53
Merge branch 'master' of github.com:mailgun/mailgun-php
oleksandr-mykhailenko c8a5976
Correcting params to the method. Updated php docs
oleksandr-mykhailenko 83c07b4
Correcting params to the method. Updated php docs
oleksandr-mykhailenko 0e6a4f7
Correcting params to the method. Updated php docs
oleksandr-mykhailenko 4a04fbd
Correcting params to the method. Updated php docs
oleksandr-mykhailenko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checking: should this
break
have been added? There's a comment two lines below that says "no break", and the comment above that seems to explain why.json_encode
could returnfalse
, so perhaps that's what was being avoided here.I haven't read through any of this code, so I don't know what it does, and I'm not using this version, so I don't know whether it breaks or improves anything. I just happened across this and thought I'd point it out and ask.