Laminas module version #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Renaming "zend" prefixed variables to more standard names - Removal of unused $data array computation code in Mail/Transport.php - Addition of use instructions in Mail/Transport.php - Addition of composer dependency to laminas-mail and laminas-http modules (No version constraint because I have no history of those modules versions)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Concerning the #11 issue, I've made a commit to correct the following :
As the laminas-mail module is discontinued, I'm assuming that a version check is not relevant.
For the laminas-http module, I'm assuming that the Laminas\Http\Client\Adapter\Socket will be kept as is for now.
The dependencies in the composer.json are not required as no real dependency was given until now (Even tho the Magento\Framework and Zend\Http and Zend\Mail were required).
Do not hesitate if you have any change you want me to do before merging.
Regards,
Baptiste