Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make updates resulting from doc review #38

Merged
merged 2 commits into from
Jan 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,20 @@ All notable changes to the process_executer gem will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## v1.0.0 (2023-12-31)

[Full Changelog](https://github.com/main-branch/process_executer/compare/v0.7.0..v1.0.0)

Changes since v0.7.0:

* e11f03e Separate semver PR label check into its own workflow (#36)
* eabcc3e Update min req Ruby version from 2.7 to 3.0 (#32)
* 5483bb8 Update spec_helper.rb to new standard (#31)
* 4a27341 Update all development dependencies to latest versions (#30)
* ea7513d Enforce that a semver label is present on PRs (#28)
* 0aa26cd Instruct Rubocop that dev deps go in gemspec (#29)
* 53cb526 Add a truffle-ruby build on ubuntu (#18)

## v0.7.0 (2023-02-17)

[Full Changelog](https://github.com/main-branch/process_executer/compare/v0.6.1..v0.7.0)
Expand Down
5 changes: 3 additions & 2 deletions lib/process_executer.rb
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@
module ProcessExecuter
# Execute the specified command as a subprocess and return the exit status
#
# This method blocks until the command has terminated.
# This is a convenience method that calls Process.spawn and blocks until the
# command has terminated.
#
# The command will be send the SIGKILL signal if it does not terminate within
# the specified timeout.
Expand All @@ -38,7 +39,7 @@ module ProcessExecuter
# documentation for valid command and options
#
# @see ProcessExecuter::Options#initialize See ProcessExecuter::Options#initialize
# for additional options that may be specified
# for options that may be specified
#
# @param command [Array<String>] the command to execute
# @param options_hash [Hash] the options to use when exectuting the command
Expand Down
7 changes: 4 additions & 3 deletions lib/process_executer/options.rb
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,14 @@ class Options
close_others chdir
].freeze

# These options are allowed but should NOT be passed to `Process.spawn`
# These options are allowed by `ProcessExecuter.spawn` but should NOT be passed
# to `Process.spawn`
#
NON_SPAWN_OPTIONS = %i[
timeout
].freeze

# Any `SPAWN_OPTIONS`` set to this value will not be passed to `Process.spawn`
# Any `SPAWN_OPTIONS` set to `NOT_SET` will not be passed to `Process.spawn`
#
NOT_SET = :not_set

Expand Down Expand Up @@ -76,7 +77,7 @@ class Options
# @param options [Hash] Process.spawn options plus additional options listed below.
#
# See [Process.spawn](https://ruby-doc.org/core/Process.html#method-c-spawn)
# for a list of valid.
# for a list of valid options that can be passed to `Process.spawn`.
#
# @option options [Integer, Float, nil] :timeout
# Number of seconds to wait for the process to terminate. Any number
Expand Down
2 changes: 1 addition & 1 deletion lib/process_executer/version.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@

module ProcessExecuter
# The current Gem version
VERSION = '0.7.0'
VERSION = '1.0.0'
end
1 change: 1 addition & 0 deletions process_executer.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ Gem::Specification.new do |spec|
spec.metadata['homepage_uri'] = spec.homepage
spec.metadata['source_code_uri'] = 'https://github.com/main-branch/process_executer'
spec.metadata['changelog_uri'] = 'https://rubydoc.info/gems/process_executer/file/CHANGELOG.md'
spec.metadata['documentation_uri'] = "https://rubydoc.info/gems/process_executer/#{ProcessExecuter::VERSION}"

# Specify which files should be added to the gem when it is released.
# The `git ls-files -z` loads the files in the RubyGem that have been added into git.
Expand Down