Improved negative population in efficiency rating #3128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added QI stats to BoostsSum added Coin/Supply boosts to QI building productions replaced QIStats actions with real boost (to include main city boosts)
|
As you did not respond via discord... What exactly was your train of thought here? The change does not really make sense in my eyes. Currently, If a building needs population (e.g. pumpkins), their score is reduced by the same amount as other buildings that provide population have their score increased. The score is more or less redistributed between the buildings. Your change seems kind of random and the divisor of 1000000 seems very arbitrary: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just a quick change to rate negative population better in the rating.
Currently, it scales in the wrong way (increasing your demanded pop makes them seem better, when they should get worse). This is now reversed, so if you want more pop, negative pop buildings are rated worse.