do not lowercase driver names that are FQNs of PHP classes #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change, SessionHandler storage drivers could only be added by adding new classes to the horde/sessionhandler package. There are situations when this is undesirable, e.g. if an app package wants to use its own custom SessionHandler storage driver that would not be useful on its own without the app. With this small change in the driver loading code, a driver class can now be part of any package, given that it is configured in Horde's config with its FQN, e.g.: "conf['sessionhandler']['type'] = '\Horde\Acme\SessionHandler\Storage\Acme';".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, SessionHandler storage drivers could only be added by adding new classes to the horde/sessionhandler package. There are situations when this is undesirable, e.g. if an app package wants to use its own custom SessionHandler storage driver that would not be useful on its own without the app. With this small change in the driver loading code, a driver class can now be part of any package, given that it is configured in Horde's config with its FQN, e.g.: "conf['sessionhandler']['type'] = '\Horde\Acme\SessionHandler\Storage\Acme';".