Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-3352] fix: board layout redirection bug in work item #6584

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

anmolsinghbhatia
Copy link
Collaborator

@anmolsinghbhatia anmolsinghbhatia commented Feb 11, 2025

Description

This PR addresses a bug where the board layout work item was not redirecting correctly.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

References

[WEB-3352]

Summary by CodeRabbit

  • Bug Fixes
    • Corrected the navigation links for issue details so standard issues now correctly direct to their respective pages, ensuring a consistent and accurate user experience.

Copy link
Contributor

coderabbitai bot commented Feb 11, 2025

Walkthrough

The pull request updates the URL construction in the Kanban issue block component. Specifically, the href property for the ControlLink component is modified to use "issues" instead of "work items" when the isEpic flag is false. This adjustment ensures the proper URL is generated for standard issues while epics retain their original handling. No other component logic or exported entities were modified.

Changes

File(s) Change Summary
web/core/components/.../block.tsx Updated the href in the ControlLink component, switching the URL segment from "work items" to "issues" when the isEpic flag is false.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant K as KanbanIssueBlock
    participant C as ControlLink
    participant R as Router

    U->>K: Clicks on issue block
    K->>C: Render link based on isEpic flag
    alt isEpic is false
        C->>R: Navigate to /issues/:id
    else isEpic is true
        C->>R: Navigate to /work_items/:id
    end
Loading

Possibly related PRs

Suggested labels

🐛bug, 🌐frontend

Suggested reviewers

  • sriramveeraghanta
  • gurusainath

Poem

I'm a rabbit with a code delight,
Hopping through branches both day and night,
Changing links from "work items" to "issues" so true,
A little hop for bugs, a great leap for our view,
🐇 Cheers to crisp code and a future bright!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4fd8b4a and 0b4494f.

📒 Files selected for processing (1)
  • web/core/components/issues/issue-layouts/kanban/block.tsx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Analyze (javascript)
  • GitHub Check: Analyze (python)
🔇 Additional comments (1)
web/core/components/issues/issue-layouts/kanban/block.tsx (1)

218-220: LGTM! URL construction fix looks correct.

The URL construction now properly differentiates between issues and epics, fixing the board layout redirection bug. The change handles both archived and non-archived items correctly.

Let's verify that this is the only instance of the URL pattern that needed updating:

✅ Verification successful

🏁 Script executed:

#!/bin/bash
# Search for similar URL patterns in the codebase to ensure consistency
rg -g '*.{ts,tsx}' '["/](?:work-?items|issues|epics)["/]'

Length of output: 62481


URL construction consistency verified.

The search revealed that all URL constructions across the codebase consistently use either "issues" or "epics", and no outdated "work-items" pattern appears. The change in web/core/components/issues/issue-layouts/kanban/block.tsx correctly handles both archived and non-archived items with:

  • /[workspaceSlug]/projects/[issue.project_id]/[archives/]{if archived}[epics/ or issues/][issue.id]

No additional instances require an update.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@anmolsinghbhatia anmolsinghbhatia changed the title [WEB-3353] fix: board layout redirection bug in work item [WEB-3352] fix: board layout redirection bug in work item Feb 11, 2025
@sriramveeraghanta sriramveeraghanta merged commit 7aa5b6a into preview Feb 11, 2025
12 of 14 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix-board-layout-redirection branch February 11, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants