fix: Handled workspace switcher closing on click

[gakshita]

Description
Handled workspace switcher closing on click

Summary by CodeRabbit

• New Features

  • Sidebar dropdown now closes automatically upon navigation, leading to a smoother user experience.

• Refactor

  • Streamlined component interactions and simplified event handling for cleaner and more maintainable code.

[coderabbitai]

Walkthrough

This pull request updates two sidebar components to improve dropdown functionality. The SidebarDropdownItem now accepts a new handleClose prop to trigger dropdown closure on link clicks, while the SidebarDropdown component’s Menu render prop is enhanced by adding a close parameter. Additionally, the code undergoes formatting improvements for clarity and conciseness.

Changes

File	Change Summary
web/core/.../sidebar/dropdown-item.tsx	Added a handleClose: () => void; prop and updated the onClick handlers for links to invoke it for closing the dropdown.
web/core/.../sidebar/dropdown.tsx	Reformatted the modifiers array, added a close parameter to the Menu render prop, and simplified the workspace navigation function definition.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant SDI as SidebarDropdownItem
    participant SB as SidebarDropdown/Menu
    U->>SDI: Click on settings/members link
    SDI->>SB: Invoke handleClose via the close parameter
    SB-->>SDI: Dropdown closed, navigation proceeds

Loading

Possibly related PRs

• makeplane/plane#6570: Addresses modifications in the SidebarDropdownItem component with the introduction of the handleClose prop.
• makeplane/plane#6574: Updates the Menu component's render prop by adding the close parameter for consistent dropdown closure.

Suggested labels

🌐frontend

Suggested reviewers

• pablohashescobar
• sriramveeraghanta

Poem

I'm a rabbit with a coding beat,
Hoping through dropdowns, neat and fleet.
With close commands in every click,
My sidebar’s magic does the trick.
Carrots and code—what a treat!

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4fd8b4a and 5683d94.

📒 Files selected for processing (2)

• web/core/components/workspace/sidebar/dropdown-item.tsx (2 hunks)
• web/core/components/workspace/sidebar/dropdown.tsx (4 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Analyze (javascript)
• GitHub Check: Analyze (python)

🔇 Additional comments (4)

web/core/components/workspace/sidebar/dropdown-item.tsx (2)

22-22: LGTM! Props interface updated correctly.

The new handleClose prop is properly typed as a function with void return type.

---

93-93: LGTM! Dropdown closing behavior implemented correctly.

The handleClose function is appropriately called in the onClick handlers of both settings and members links, ensuring the dropdown closes when navigating to these pages.

Also applies to: 101-101

web/core/components/workspace/sidebar/dropdown.tsx (2)

79-79: LGTM! Menu render prop correctly destructured.

The close function is properly extracted from the Menu render prop, making it available for child components.

---

134-134: LGTM! Close function correctly passed to child component.

The close function is properly passed down to SidebarDropdownItem through the handleClose prop, completing the dropdown closing implementation.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.