[WEB-3352] fix: home recent item redirection #6586
Conversation
|
Warning Rate limit exceeded@anmolsinghbhatia has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 15 minutes and 2 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (3)
WalkthroughThis pull request updates the dynamic URL generation in several Recents widget components. In the issue, page, and project components, hardcoded or empty string values assigned to the Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant C as Recents Component
participant G as URL Generator
participant L as ListItem
participant R as Router
U->>C: Render recents widget
C->>G: Construct dynamic URL (workItemLink/pageLink/projectLink)
G-->>C: Return constructed URL
C->>L: Pass URL as itemLink prop
U->>L: Click on list item
L->>R: Trigger navigation via onItemClick or link
R-->>U: Navigate to dynamic URL
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
web/core/components/home/widgets/recents/issue.tsx(1 hunks)web/core/components/home/widgets/recents/page.tsx(1 hunks)web/core/components/home/widgets/recents/project.tsx(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Analyze (javascript)
- GitHub Check: Analyze (python)
🔇 Additional comments (2)
web/core/components/home/widgets/recents/page.tsx (1)
32-34: LGTM! URL construction handles both project and standalone pages.The URL construction logic correctly differentiates between project-specific pages and standalone pages, ensuring proper redirection.
Also applies to: 39-39
web/core/components/home/widgets/recents/issue.tsx (1)
100-104: Consider using workItemLink in onItemClick.The
onItemClickhandler usessetPeekIssuewith individual props while we have a constructed URL. Consider if these should be consistent.Please verify:
- Should clicking use the peek functionality or navigate to the URL?
- If peek is correct, should we update
itemLinkto also trigger peek instead of navigation?
anmolsinghbhatia
changed the title
Description
This PR addresses a home recent item redirection bug where the item was not redirecting correctly.
Type of Change
References
[WEB-3352]
Summary by CodeRabbit