Allow specifying xPad, yPad individually (ref #19) #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the group methods, there is two types of padding: between subviews and between the group and its sibling or superview. In all the grouping methods (except groupInCenter), we want to allow specifying the xPad and yPad values individually, so that the user can control both the padding between subviews and the padding between the group and its superview.
|
Ping @mamaral |
|
My first thoughts going over this is that if we wanted to go to this extent, why not make it fully customizable for all situations, i.e. allow them to specify xPad, yPad, and spacing? Then its less ambiguous as to what you're setting, and you can lay it out however you want? |
|
Makes sense - thanks. I will be revising the PR soon. Thanks again for your feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt at addressing the issue I raised in #19. Obviously we should add some tests for the case where xPad != yPad, but I wanted to get this out there quickly for discussion/feedback.
Notes:
Depending on the specific combination of horizontal/vertical with top/left/bottom/right, the xPad and yPad values can both affect the resulting frame, or just one of them. Keeping track of which combinations allow for xPad and/or yPad to affect the resulting frame will allow us to (if desired) breakout methods by these groups so that no method parameter is redundant.
Which padding values affect the resulting frame:
groupAgainstEdge:
Horizontal:
Vertical: