rtld: invoke fini functions #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 352b2f7.
64
force-pushed
the
rtld-fini
branch
2 times, most recently
from
1371687 to
94d3c42
Compare
Geertiebear
reviewed
Oct 15, 2024
|
I'd prefer to not support circular dependencies as these are quite broken anyway. |
|
Agreed, I misread the code and thought it was ensuring there were no circular dependencies, but actually this code is adding explicit support for it. This PR should keep the old code. |
|
I've removed handling of circular deps and removed crt{begin,end}.S so that we no longer support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1092 was previously reverted because it caused a regression. In particular, it relied on DSOs to invoke
__cxa_finalize, but mlibc itself is missing a call to__cxa_finalizein crtbegin, so any libc-related destructors (such as the guard that flushes all open files) were not run.Fix this by adding a
[[gnu::destructor]]function which calls__cxa_finalizewith our own__dso_handle.Also, while refactoring, I noticed that the
crt{begin,end}.Sare no longer needed (they were used for.ctor/.dtorhandling, which we no longer use), and provided the definition of__dso_handle(which I've moved into C++).Also add a regression test to ensure we run libc destructors somehow.