misc: Remove include-fixed include path #950
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no92
approved these changes
Nov 26, 2023
There was a problem hiding this comment.
LGTM as I fundamentally agree, however I would want to see whether we can get a full world rebuild with this and roll back if needed.
Originally, this seems to have been added by @avdgrinten, maybe he can enlighten us on why this was added to begin with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the include-fixed include directory breaks the build if the directory actually has some system headers. For an example on Gentoo there is pthread.h there and when building mlibc it gets included instead of the mlibc pthread.h causing the build to fail.