Correct the return type for getItem in MemoryStorage #1350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any updates on this? Please refer to the spec when in doubt: https://tc39.es/ecma262/multipage/keyed-collections.html#sec-map.prototype.get |
L-X-T
force-pushed
the
master
branch
4 times, most recently
from
a54ea92 to
078415b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Memory storage uses a
Mapas backing storage. However, theMapreturn type forgetis not purelystring, it could also beundefined, hence this PR. (see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Map/get)Another suggestion is that using
MemoryStoragewill save the nonce, if used, in memory as well, making it easy to make a whoopsie (see my other PR). Perhaps thisMemoryStorageshould at least warn about not saving a nonce there?