added check for integer being key in object #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previous behaviour:
data = '{42:{"key":"value", "key2":"value2"}}'
repair_json(data) -> '{"key":"value", "key2":"value2"}'
new behaviour:
repair_json(data) -> '{"42":{"key":"value", "key2":"value2"}}'
|
Hi, thanks for submitting. Before I review, this library uses TDD, so any change must have new tests added as well. Cheers |
added test for changing alphanumeric
|
Added test that checks for new behavior. This test also should fail for old behaviour |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previous behaviour:
data = '{42:{"key":"value", "key2":"value2"}}'
repair_json(data) -> '{"key":"value", "key2":"value2"}'
new behaviour:
repair_json(data) -> '{"42":{"key":"value", "key2":"value2"}}'
Issue #
bugfix
What is the current behavior?
Currently repair_json fixes missing quotes only for alpha keys, however alphanumeric are also valid keys
What is the new behavior?
repair_json also fixes alphanumeric keys missing quotes
Does this introduce a breaking change?
Other information