Rspec 3, flexible initialize block, fixes method_missing approach (prescribed use by twilio-ruby) #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the twilio README recommends using the method_missing approach to account (it forwards calls to the account object)
This was referenced Feb 5, 2015
|
Working great for me. Thanks for the fix! 👍 |
|
@manlycode is this maintained or abandoned? |
|
@manlycode Hi. Just wondering if you were planning on merging this PR. Thanks! |
* From ~> 3.1.0 to ~> 3.1 to be able to update to version 3.4
Weaken RSpec dependency
manlycode
added a commit
that referenced
this pull request
Feb 29, 2016
Rspec 3, flexible initialize block, fixes method_missing approach (prescribed use by twilio-ruby)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves #19, #18, and #13. The rspec test is fully updated and all tests pass.
The
method_missingapproach appears to be the prescribed use in the README such as:This now works and is tested the same as the approach using
@client.account.messagesetc.