Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

38661 update test instructions #38702

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Conversation

warunawickramasingha
Copy link
Contributor

Description of work

Updated manual testing instructions as requested in #38661

Fixes #38661.

To test:

1- dev-docs-html target should build without any error/warings.
2- Open the index.html from \build\dev-docs\html
3- Search for the below pages and follow the test instructions in the below sections

  • Inelastic QENS Fitting Testing :: Convolution tab
  • Inelastic Corrections Testing :: Calculate Monte Carlo Absorption Tab

4- check the requested test instruction changes are available

Note: Release notes were not added since it is just an update in test instructions.


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@warunawickramasingha warunawickramasingha added this to the Release 6.13 milestone Jan 27, 2025
@warunawickramasingha warunawickramasingha added the Documentation Issues and pull requests related to documentation label Jan 27, 2025
Copy link
Contributor

@GuiMacielPereira GuiMacielPereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built the documentation and checked these changes were there. The changes make sense.

@rbauststfc rbauststfc self-assigned this Jan 30, 2025
@rbauststfc rbauststfc merged commit b26b653 into main Jan 30, 2025
10 checks passed
@rbauststfc rbauststfc deleted the 38661_update_test_instructions branch January 30, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Issues and pull requests related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6.12 Manual Testing - Testing Instruction Maintenance
3 participants