Fix missed jar path reassignment in jenkins-agent script #38707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cailafinn
added
the
High Priority
Just noticed another issue with the "already running" check. Just need to fix that. |
MialLewis
previously approved these changes
Jan 27, 2025
MialLewis
reviewed
Jan 27, 2025
buildconfig/Jenkins/jenkins-agent.sh
Outdated
| @@ -69,6 +69,24 @@ ARM_JAR_FILE=agent.jar | |||
| # Script | |||
| ##################################################################### | |||
| # exit if it is already running | |||
There was a problem hiding this comment.
Should this be on line 89?
cailafinn
force-pushed
the
jenkins-agent_arm_mac
branch
from
7cc53d3 to
576c4db
Compare
MialLewis
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Summary of work
Fixes a mistake in #38693 which meant the path to the jar file wasn't being reassigned after the search/download steps.
Purpose of work
There is no associated issue.
To test:
This does not require release notes because it's a dev-ops script.
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.