Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLASH: Upgrade Pyinstaller to 6.7.* #2262

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

MikeSullivan7
Copy link
Collaborator

Description

Pyinstaller has been updated to version 6.7.*.
This solves an issue where No module named 'pkg_resources.extern' error occurs when building using Pyinstaller. We normally get this module from setuptools but the way modules were imported changed recently with version 70.0.0. Pyinstaller was updated to take this into account and use a workaround. More details can be found here:

pypa/setuptools#4374

@MikeSullivan7 MikeSullivan7 added the dependencies Pull requests that update a dependency file label Jul 9, 2024
@MikeSullivan7 MikeSullivan7 self-assigned this Jul 9, 2024
@coveralls
Copy link

Coverage Status

coverage: 73.14%. remained the same
when pulling 37fc5be on FLASH_upgrade_pyinstaller_6.7.0
into dcafc8f on main.

@samtygier-stfc samtygier-stfc self-requested a review July 9, 2024 12:36
Copy link
Collaborator

@samtygier-stfc samtygier-stfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build and works on Linux.

@samtygier-stfc samtygier-stfc added this pull request to the merge queue Jul 9, 2024
Merged via the queue into main with commit c474bf5 Jul 9, 2024
7 checks passed
@samtygier-stfc samtygier-stfc deleted the FLASH_upgrade_pyinstaller_6.7.0 branch July 9, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants