-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move File -> Load 180 Projection to Add / Replace Stack dialog #2403
Merged
samtygier-stfc
merged 8 commits into
main
from
2367_move_load_180_proj_to_add_replace_stack
Nov 21, 2024
Merged
Move File -> Load 180 Projection to Add / Replace Stack dialog #2403
samtygier-stfc
merged 8 commits into
main
from
2367_move_load_180_proj_to_add_replace_stack
Nov 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtygier-stfc
requested changes
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice clean up.
I think MainWindowPresenter.add_180_deg_file_to_dataset
can also be removed now. and maybe MainWindowModel.add_180_deg_to_dataset()
.
Note: has updates to main_window_test screenshots |
samtygier-stfc
approved these changes
Nov 21, 2024
samtygier-stfc
deleted the
2367_move_load_180_proj_to_add_replace_stack
branch
November 21, 2024 14:13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Close #2367
Description
The option to load a 180 projection image has been removed from the File menu to the right click "Add / Replace Stack" menu in the file tree in the main Window.
Related View Tests have been removed to reflect the changes in the Main Window View.
Testing
make test
Acceptance Criteria
Load a dataset into MantidImaging without a 180 degree projection image.
Once loaded, right click the dataset tree in the Main Window and select "Add / Replace Stack".
Under "Image Type", select "Proj 180" and add an image, check that it loads into the dataset correctly.