Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move File -> Load 180 Projection to Add / Replace Stack dialog #2403

Merged
merged 8 commits into from
Nov 21, 2024

Conversation

MikeSullivan7
Copy link
Collaborator

Issue

Close #2367

Description

The option to load a 180 projection image has been removed from the File menu to the right click "Add / Replace Stack" menu in the file tree in the main Window.
Related View Tests have been removed to reflect the changes in the Main Window View.

Testing

make test

Acceptance Criteria

Load a dataset into MantidImaging without a 180 degree projection image.
Once loaded, right click the dataset tree in the Main Window and select "Add / Replace Stack".
Under "Image Type", select "Proj 180" and add an image, check that it loads into the dataset correctly.

image

@coveralls
Copy link

coveralls commented Nov 18, 2024

Coverage Status

coverage: 74.202% (-0.02%) from 74.22%
when pulling 68f80e6 on 2367_move_load_180_proj_to_add_replace_stack
into 507d6e8 on main.

Copy link
Collaborator

@samtygier-stfc samtygier-stfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up.
I think MainWindowPresenter.add_180_deg_file_to_dataset can also be removed now. and maybe MainWindowModel.add_180_deg_to_dataset().

@samtygier-stfc
Copy link
Collaborator

Note: has updates to main_window_test screenshots

@samtygier-stfc samtygier-stfc added this pull request to the merge queue Nov 21, 2024
Merged via the queue into main with commit c7980a2 Nov 21, 2024
8 checks passed
@samtygier-stfc samtygier-stfc deleted the 2367_move_load_180_proj_to_add_replace_stack branch November 21, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relocated Load 180 deg projection into Add / Replace Stack
3 participants