Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Init to Spectrum Widget Folder #2443

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

JackEAllen
Copy link
Collaborator

@JackEAllen JackEAllen commented Jan 6, 2025

Issue

Closes #2442

Description

MI fails to start with the error message
ModuleNotFoundError: No module named 'mantidimaging.gui.widgets.spectrum_widgets'

Looks like an import error, where something is working fine from the source directory but not in the package.

After further investigation, A missing __init__ seemed to be the culprit which has now been added to mantidimaging/gui/widgets/spectrum_widgets/

Testing

Describe the tests that were used to verify your changes.

  • Build locally with make build-conda-package and install into mantidimaging-nightly using mamba install /home/sam/mambaforge/envs/build-env/conda-bld/linux-64/mantidimaging-2.9.0a1.post402-py312_1.tar.bz2
    • Verify if that that package bultds correctly and can be installed and ran wihtout any import errors

Acceptance Criteria

Mi can build successfully without returning a ModuleNotFoundError error

Documentation

How have you changed the documentation to reflect your changes? All changes should be noted in the appropriate file in docs/release_notes

NA - This is a flash PR and does not change MI in any significant way.

@coveralls
Copy link

Coverage Status

coverage: 73.618% (+0.002%) from 73.616%
when pulling 77002df on 2442-spectrum_import_on_build_error
into 2da9f72 on main.

@samtygier-stfc
Copy link
Collaborator

If I build locally with make build-conda-package and install into mantidimaging-nightly with mamba install /home/sam/mambaforge/envs/build-env/conda-bld/linux-64/mantidimaging-2.9.0a1.post402-py312_1.tar.bz2, it fixes the issue.

Doing the same with main I get the ModuleNotFoundError.

@JackEAllen JackEAllen marked this pull request as ready for review January 6, 2025 16:08
@samtygier-stfc samtygier-stfc changed the title Add Init to Dpectrum Widget Folder Add Init to Spectrum Widget Folder Jan 6, 2025
@samtygier-stfc samtygier-stfc added this pull request to the merge queue Jan 6, 2025
Merged via the queue into main with commit 9278674 Jan 6, 2025
8 checks passed
@samtygier-stfc samtygier-stfc deleted the 2442-spectrum_import_on_build_error branch January 6, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MI failing to start on IDAaaS
3 participants