Fix for ROI Addition After Exporting CSV #2458
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackEAllen
requested changes
Jan 20, 2025
Comment on lines
+442
to
+443
| spectrum_values = [v for v in self.spectrum_widget.spectrum_data_dict.values() if v is not None] | ||
| tof_data = np.arange(len(spectrum_values[0]) if spectrum_values else 0) |
There was a problem hiding this comment.
Can we give V a more descriptive name please
Comment on lines
+442
to
+443
| spectrum_values = [v for v in self.spectrum_widget.spectrum_data_dict.values() if v is not None] | ||
| tof_data = np.arange(len(spectrum_values[0]) if spectrum_values else 0) |
There was a problem hiding this comment.
I think we are okay to use .size here as spectrum_values should always be an np.ndarray.
tof_data = np.arange(spectrum_values[0].size if spectrum_values else 0)| @@ -437,9 +437,14 @@ def set_roi_visibility_flags(self, roi_name: str, visible: bool) -> None: | |||
| self.show_visible_spectrums() | |||
|
|
|||
| def show_visible_spectrums(self) -> None: | |||
There was a problem hiding this comment.
As this method does a few things now, can we add a docstring to explain what the method does.
| @@ -0,0 +1 @@ | |||
| 2422: Spectrum viewer: cant add an ROI after exporting CSV | |||
There was a problem hiding this comment.
Can we re-word this slightly to say what the proposed change is resolving, maybe something like:
"Spectrum viewer: Resolves a bug preventing a new ROI from being added after exporting to a CSV file,"
samtygier-stfc
requested changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #2422
Description
This PR resolves an issue in the Spectrum Viewer where adding new ROIs fails after exporting a CSV file. The problem was caused by tof_data becoming unavailable post-export.
Acceptance Criteria
Open a dataset (without the spectra file), open the spectum viewer
Click "Add" to add an ROI
Click "Export Spectrum" and choose name to save an CSV file
Click "Add" to add an ROI
A new ROI should be successfully added and displayed in the Spectrum Viewer
Documentation
All changes should be noted in the appropriate file in docs/release_notes