Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle TypeError in Live Viewer due to slow FITS files #2476

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MikeSullivan7
Copy link
Collaborator

Issue Closes #2469

Description

When loading an image inside display_image, we now include TypeError to catch the instance when the Live Viewer attempts to read a FITS file that has not completed moving to the LV path, leading to a TypeError raise from astropy.

Developer Testing

tests pass with make check and make test-system

Acceptance Criteria and Reviewer Testing

  • Unit tests pass locally: make check and make test-system
  • Open the LV and transfer FITS files to the path via python simulate_live_data.py using --mode slow
  • Check that no error dialogs appear, even if errors and warnings appear in the terminal

Documentation and Additional Notes

  • Release Notes have been updated

@MikeSullivan7 MikeSullivan7 marked this pull request as ready for review January 23, 2025 17:50
@MikeSullivan7 MikeSullivan7 self-assigned this Jan 23, 2025
@coveralls
Copy link

coveralls commented Jan 24, 2025

Coverage Status

coverage: 73.116% (+0.002%) from 73.114%
when pulling dbf119b on 2469_LV_slow_fits
into 1166cb4 on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Live viewer error with slow fits files
2 participants