hll: move constexpr from .h to .cpp

maoli17 · Mar 19, 2020 · dcf3074 · dcf3074
1 parent a71eb9e
commit dcf3074
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 9 deletions.
diff --git a/adv/hll.cpp b/adv/hll.cpp
@@ -6,6 +6,11 @@
 #include "hll.h"
 
 namespace hll {
+constexpr uint8_t CLZ_TABLE_4BIT[16] = {4, 3, 2, 2, 1, 1, 1, 1,
+                                        0, 0, 0, 0, 0, 0, 0, 0};
+constexpr uint64_t L8 = 0x0101010101010101;
+constexpr uint64_t H8 = 0x8080808080808080;
+constexpr uint64_t A1 = 0xffffffffffffffff;
 
 double alpha(const int m) {
     switch (m) {

diff --git a/adv/hll.h b/adv/hll.h
@@ -11,12 +11,6 @@
 
 namespace hll {
 
-constexpr uint8_t CLZ_TABLE_4BIT[16] = {4, 3, 2, 2, 1, 1, 1, 1,
-                                        0, 0, 0, 0, 0, 0, 0, 0};
-constexpr uint64_t L8 = 0x0101010101010101;
-constexpr uint64_t H8 = 0x8080808080808080;
-constexpr uint64_t A1 = 0xffffffffffffffff;
-
 double alpha(const int m);
 
 double beta(const double ez);
@@ -43,7 +37,6 @@ bool isGreaterEqual(const uint64_t& x, const uint64_t& y);
  */
 double count(const uint8_t* reg, const int m);
 
-
 } /* namespace hll */
 
 #endif /* __HYPER_LOGLOG_COUNTING_H__ */
diff --git a/graph/hyperanf.h b/graph/hyperanf.h
@@ -35,7 +35,6 @@ class HyperANF {
     /**
      * Merge HLL counter at pos_j to HLL counter at pos_i.
      * B(C_i) := max(B(C_i), B(C_j))
-     * Return true if value in pos_i is changed.
      */
     inline void mergeCounter(const int pos_i, const int pos_j) {
         for (int k = 0; k < units_per_counter_; k++) {
@@ -46,7 +45,6 @@ class HyperANF {
 
     /**
      * Merge counter at pos to given target.
-     * Return true if value in pos_i is changed.
      */
     inline void mergeCounter(uint64_t* target, const int pos) const {
         for (int k = 0; k < units_per_counter_; k++) {