-
-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add globe/mercator button #963
base: main
Are you sure you want to change the base?
Conversation
I would recommend adding a test... |
Do you mind helping me with the test? I don't know cypress but happy to learn about it if you can help me a bit |
sure, this repo has a good practice when it comes to end-to-end tests. Let me know if the above is enough or not. |
The maplibre packages' versions were updated to use latest ones, can you update the branch? It should reduce changes as part of this PR as well. |
Need rebase, since main is on GL JS 5 |
hardcode projections
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #963 +/- ##
==========================================
+ Coverage 59.84% 62.53% +2.68%
==========================================
Files 104 104
Lines 3011 5786 +2775
Branches 680 1720 +1040
==========================================
+ Hits 1802 3618 +1816
- Misses 1209 2167 +958
- Partials 0 1 +1 ☔ View full report in Codecov by Sentry. |
Launch Checklist
Adds a button for choosing the projection globe or mercator. Appears under the light settings. Live demo is here: https://wipfli.github.io/maputnik/?layer=1455082206%7E0&modal=settings#1.02/0/0
CHANGELOG.md
under the## main
section.