Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for FillStyleLayer #66

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Add support for FillStyleLayer #66

merged 2 commits into from
Jan 9, 2025

Conversation

hactar
Copy link
Collaborator

@hactar hactar commented Dec 22, 2024

Issue/Motivation

This PR adds support for MGLFillStyleLayer via FillStyleLayer. I based this off of LineStyleLayer but adjusted the properties. Included the properties that I currently need for a project, the todo of adding them all still applies.

Screenshot 2024-12-22 at 21 56 37

Tasklist

  • Include tests (if applicable) and examples (new or edits)
  • If there are any visual changes as a result, include before/after screenshots and/or videos
  • Add #fixes with the issue number that this PR addresses
  • Update any documentation for affected APIs
  • Update the CHANGELOG

@hactar hactar requested a review from ianthetechie December 22, 2024 21:52
@hactar hactar requested a review from Archdoog December 23, 2024 09:29
Copy link
Collaborator

@ianthetechie ianthetechie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh, nice! I am also embarrased to realize that I have a stash with basically the exact same thing from September that I never finished 😅 Thanks for adding this.

@ianthetechie ianthetechie added the norelease Don't create an automatic release label Jan 9, 2025
@ianthetechie ianthetechie merged commit 4040a2f into main Jan 9, 2025
2 checks passed
@ianthetechie ianthetechie deleted the fillstylelayer branch January 9, 2025 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
norelease Don't create an automatic release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants