Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove node versions 21 and fix node version bump bugs #2195

Merged
merged 6 commits into from
Dec 5, 2023

Conversation

CollinBeczak
Copy link
Collaborator

@CollinBeczak CollinBeczak commented Dec 1, 2023

Remove node 21, and revert @rjsf/core version to work with existing forms.
This error is caused by the latest version of @rjsf/core.
Screenshot 2023-11-30 at 1 44 21 PM
removed node 21 because of this error:
Screenshot 2023-12-01 at 11 06 39 AM

@CollinBeczak CollinBeczak marked this pull request as ready for review December 1, 2023 23:36
@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (df6df06) 23.74% compared to head (761d37b) 23.74%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2195      +/-   ##
==========================================
- Coverage   23.74%   23.74%   -0.01%     
==========================================
  Files         648      648              
  Lines       22311    22311              
  Branches     6871     6871              
==========================================
- Hits         5298     5297       -1     
- Misses      14225    14226       +1     
  Partials     2788     2788              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CollinBeczak CollinBeczak changed the title Remove node versions 16 and 21 Remove node versions 21 and fix node version bump bugs Dec 4, 2023
@jschwarz2030 jschwarz2030 merged commit ceec577 into main Dec 5, 2023
5 checks passed
@CollinBeczak CollinBeczak deleted the removeNode16and21 branch January 15, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants