-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Elevation API and extend Elevation Preview #1432
Conversation
- pmtile coordinates - pixel calculation - swapped lat / long - allow tileSize to be configured - allow any zoom for coordinates
public/templates/data.tmpl
Outdated
|
||
map.addControl( | ||
new ElevationInfoControl({ | ||
url: baseUrl + "/data/{{id}}/elevation/{z}/{x}/{y}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of adding baseUrl do you think you can use {{public_url}} like the javascript links in the header
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's ok, you probably got the baseUrl thing from the contour test I posted :-) I didn't think of that then..haha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, it's still in my PR to your PR ;-)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me now
I added a Info field to the elevation preview, which queries the elevation api with coordinates.
During the implementation I stumbled over various issues: