WIP: Add contour line endpoint for terrain #1458
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Andrew Calcutt <[email protected]>
Co-authored-by: Andrew Calcutt <[email protected]>
This reverts commit 0619a98.
Co-Authored-By: Andrew Calcutt <[email protected]>
Co-Authored-By: Andrew Calcutt <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -0,0 +1,65 @@ | |||
| class MaplibreContourControl { | |||
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
| $zxy.z, | ||
| $zxy.x, | ||
| $zxy.y, | ||
| abortController, |
Check warning
Code scanning / CodeQL
Superfluous trailing arguments Warning
acalcutt
changed the title
acalcutt
commented
Feb 5, 2025
| }, | ||
| "contour": { | ||
| "type": "vector", | ||
| "tiles": [ baseUrl + "/data/{{id}}/contour/{z}/{x}/{y}" ], |
There was a problem hiding this comment.
One thing I would like to do is make a json endpoint for the contour lines, so this does not need baseurl
I tried to use {{public_url}} here also, but "tiles" doesn't like the relative link it seemed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a maplibre-contour based endpoint, that dynamically creates contour lines that could would with either maplibre-gl-js or native