Upgrade Mapzen Android SDK #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checking this today. |
|
I'll also give this a whirl. Gonna toss this on a shiny new S8. |
tallytalwar
approved these changes
Jun 23, 2017
| @@ -116,7 +126,7 @@ public AndroidModule(EraserMapApplication application) { | |||
|
|
|||
| @Override public Map<String, String> queryParamsForRequest() { | |||
| Map<String, String> params = new HashMap<>(); | |||
| params.put(ApiKeyConstants.API_KEY, apiKeys.getApiKey()); | |||
| params.put(Http.PARAM_API_KEY, apiKeys.getApiKey()); | |||
There was a problem hiding this comment.
Maybe requires more changes (than we want with EM), but probably we should use sceneUpdate with sceneLoad for consistency with SDK usage.
There was a problem hiding this comment.
This is for interaction with Pelias so we need to append the api key. When mapzen/android#412 merges, we can use the new MapzenSearchHttpRequestHandler to append only the DNT header (the api key will be handled by the SDK)
|
@tallytalwar I created this SDK issue to investigate tile request speed: mapzen/android#413 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Upgrades EM to the latest release of the Mapzen Android SDK (1.4.0)
Proposed Changes
TileHttpHandlersuperclassTmpHttpHandlerto allow for customizing headers in tile requests. This class will be removed andTileHttpHandlerwill be updated to inherit from Tangram class when dependent work is completed (Allow customization of request headers in HttpHandler #821)Closes #816