Add bounds check to move left/right buttons in topbar cfg dialog #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure an item is actually selected and can be moved in the desired direction. I.e. don't try to move left if it is already the first item and don't move right if it is the last. Without this bounds check clicking on move left/right leads to crashes due to out of range acccesses on ui->listWidget.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure an item is actually selected and can be moved in the desired direction. I.e. don't try to move left if it is already the first item and don't move right if it is the last.
Without this bounds check clicking on move left/right in those situations leads to crashes due to out of range acccesses on ui->listWidget.