Added from edge swipe functionality

[supachris28]

Tested on Chrome ion Windows 7 using Mobile Mode
Tested on Chrome on Android Nougat

[marcandre]

Thanks for the PR.

The debugging feature feels like a definite no-no, and the fact that the events (e.g. swiperight) are replace by others (e.g. swipefromleft) is completely out of the question, in particular because it introduces major incompatibilities.

I think that maybe adding the start & end positions (maybe both absolute and relative) and letting the user decide what to do with it is a better idea. In particular, it would be easy to write a small library that relies on the current events to post the swipefrom... events, if the startX/Y warrant it.

[supachris28]

Fair enough. I never used the debug in the end as you can't see the console easily on the phone. Swipe from edge hit the use case of a user swiping in from the edge of the screen, but we found on iOS that if you do that in Safari it switches tabs anyway, so wasn't much use. On Android our implementation is great for swiping in a menu with swipefromleft, then a swipe left set on the menu element let it close nicely. If it had a start and/or end then the implementor would have to do their own calculation as to whether it is near the edge, which whilst achievable, isn't obvious. Entirely up to you though, it's your repo and we have enjoyed using it :)

…

On Mon, 20 Feb 2017, 19:01 Marc-André Lafortune, ***@***.***> wrote: Thanks for the PR. The debugging feature feels like a definite no-no, and the fact that the events (e.g. swiperight) are replace by others (e.g. swipefromleft) is completely out of the question, in particular because it introduces major incompatibilities. I think that maybe adding the start & end positions (maybe both absolute and relative) and letting the user decide what to do with it is a better idea. In particular, it would be easy to write a small library that relies on the current events to post the swipefrom... events, if the startX/Y warrant it. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#13 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ATeGMRjjVJgg1jVKig3-etS5QCH-2lAKks5reeMXgaJpZM4MELv8> .