Forgotten teardown #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used event namespacing to ensure each event type handler only affects that type and no others or user added 'swipe' handlers.
… works as expected
butesa
added a commit
to butesa/detect_swipe
that referenced
this pull request
Sep 30, 2023
based on marcandre#15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin had a
teardownfunction defined but never used. I connected it to the set-up ofswipeevent.The direction-specific events needed a different teardown, so I implemented that.
Additionally, I added an
example.htmlfile to try the plugin in a simple page. It helps to check that events are behaving as expected after changes and too the teardown (I left a comment in the teardown code about how to test the bug generated by the lack of this with the previous code).PS: Thanks for this plugin!